HTML 5 Client does not have NumLock sync

[totaam]

Issue migrated from trac ticket # 858

component: html5 | priority: major | resolution: fixed

2015-05-12 19:46:15: maxmylyn created the issue

---

Tested with the following against a Fedora 21 r9329 trunk and 0.15.0 server:

• Windows 8.1 Firefox and Chrome

• OSX 10.10 Safari

In the Windows HTML5 viewer, I can hit the NumLock button and it will work for one character, then it goes back to disabled. This is problematic as Windows will also toggle its NumLock which will cause a desync of NumLock - this was fixed in #312

In OSX, it is especially problematic as I can not enable NumLock due to Apple keyboards, annoyingly, not having a NumLock key, just a key marked 'clear' that apparently doesn't do anything.

[totaam]

2015-05-13 03:14:52: antoine commented

---

Some information that might be useful for fixing this:

• some platforms cannot provide the numlock state with mouse or keyboard events, so for those we use xkbmap_mod_missing to tell the server not to try to sync the numlock state for those events
• IIRC, some platforms send a single key event when pressing+releasing numlock..

Grepping the source code for numlock* will turn up quite a few hits.

[totaam]

2016-04-10 07:07:21: antoine changed owner from joshiggins to maxmylyn

[totaam]

2016-04-10 07:07:21: antoine commented

---

@maxmylyn: is this still a problem?

[totaam]

2016-04-12 22:03:15: maxmylyn changed owner from maxmylyn to antoine

[totaam]

2016-04-12 22:03:15: maxmylyn commented

---

As of r12379 I still do not have numlock. Hitting the NumLock key has no effect (other than toggling it on my local machine)

[totaam]

2016-06-11 18:00:26: antoine changed owner from antoine to maxmylyn

[totaam]

2016-06-11 18:00:26: antoine commented

---

Done in r12797.

Important caveat: there is no way of knowing the current state of numlock in Javascript, so we manage it ourselves and toggle the value whenever we detect that the numlock key is pressed (and we only get those events if we have focus when they occur).
So numlock can very easily start / go out of sync with the real keyboard state.

[totaam]

2016-06-13 19:54:02: maxmylyn changed status from new to closed

[totaam]

2016-06-13 19:54:02: maxmylyn set resolution to fixed

[totaam]

2016-06-13 19:54:02: maxmylyn commented

---

[[br]]

So numlock can very easily start / go out of sync with the real keyboard state.
[[br]]

Noted. Quick and dirty workaround is to disconnect, toggle numlock (so it'll match with the server), then reconnect. I'm not sure if there's going to be an elegant fix since browsers are so sandboxed.

Closing.

[totaam]

2016-06-14 10:43:14: antoine commented

---

Quick and dirty workaround is to disconnect, toggle numlock
[[BR]]
As per comment:4, you can do the same thing without disconnecting: just hit numlock whilst the xpra browser window is NOT receiving the key events (focus some other window or minimize the browser temporarily). That's a lot easier than re-connecting.

[totaam]

2016-07-12 17:52:23: antoine commented

---

Milestone renamed