Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xpra fails to start on Fedora 22 #872

Closed
totaam opened this issue May 26, 2015 · 12 comments
Closed

Xpra fails to start on Fedora 22 #872

totaam opened this issue May 26, 2015 · 12 comments

Comments

@totaam
Copy link
Collaborator

totaam commented May 26, 2015

Issue migrated from trac ticket # 872

component: server | priority: critical | resolution: fixed

2015-05-26 14:15:42: jonathan.underwood created the issue


So, the way Xorg is started has changed yet again for the Fedora 22 release.

On F22 XORG_BIN gets set to /usr/bin/Xorg which is a shell script that execs /usr/libexec/Xorg.wrap which is then supposed to exec /usr/libexec/Xorg after doing it's stuff, instead of /usr/libexec/Xorg.bin in F21.

So, that's the first problem - XORG_BIN should be being set to /usr/libexec/Xorg, rather than /usr/libexec/Xorg.bin. So, the logic in setup.py needs enhancing.

The second issue is then that, even when XORG_BIN is correctly set to /usr/libexec/Xorg in xpra_Xdummy, the X server fails to start with this:

(++) Log file: "/home/tom/.xpra/Xorg.:100.log", Time: Mon May 25 12:30:08 2015
(++) Using config file: "/etc/xpra/xorg.conf"
(==) Using config directory: "/etc/X11/xorg.conf.d"
(==) Using system config directory "/usr/share/X11/xorg.conf.d"
(EE) 
Fatal server error:
(EE) parse_vt_settings: Cannot open /dev/tty0 (No such file or directory)
(EE) 
(EE)

Downstream bug report: [https://bugzilla.redhat.com/show_bug.cgi?id=1224678]

@totaam
Copy link
Collaborator Author

totaam commented May 26, 2015

2015-05-26 14:46:40: jonathan.underwood commented


"So, the logic in setup.py needs enhancing." should read "So, the logic in xpra_Xdummy needs enhancing."

@totaam
Copy link
Collaborator Author

totaam commented May 26, 2015

2015-05-26 14:52:47: jonathan.underwood uploaded file xpra-0.14.22-fedora22-xorg.patch (0.9 KiB)

Patch to find the Xorg binary on Fedora 22

@totaam
Copy link
Collaborator Author

totaam commented May 26, 2015

2015-05-26 14:56:13: jonathan.underwood commented


OK, there's a suggested patch to xpra_Xdummy wrapper to fix the logic for finding the Xorg binary.

The second problem, i.e. the failure of Xorg to start with the xdummy driver looks likely to be this bug:

https://bugzilla.redhat.com/show_bug.cgi?id=1203780

which is a bug with the xserver, fixed in a later package - we'll test with that and report back. In the meantime, see what you think to the simple patch.

@totaam
Copy link
Collaborator Author

totaam commented May 26, 2015

2015-05-26 15:40:58: totaam changed priority from major to critical

@totaam
Copy link
Collaborator Author

totaam commented May 26, 2015

2015-05-26 15:40:58: totaam changed status from new to assigned

@totaam
Copy link
Collaborator Author

totaam commented May 26, 2015

2015-05-26 15:40:58: totaam edited the issue description

@totaam
Copy link
Collaborator Author

totaam commented May 26, 2015

2015-05-26 15:40:58: totaam changed owner from antoine to totaam

@totaam
Copy link
Collaborator Author

totaam commented May 26, 2015

2015-05-26 15:40:58: totaam commented


Applied in r9525 for all maintained branches.

It should be safe I think, there should not be any other distributions out there that use libexec and have an executable Xorg in there. (centos7 does not)

As for the other issue, I guess we can only wait for the fix to get pushed?
(will try it in a VM tomorrow)

@totaam
Copy link
Collaborator Author

totaam commented May 26, 2015

2015-05-26 15:54:14: jonathan.underwood commented


Replying to [comment:3 totaam]:

Applied in r9525 for all maintained branches.

It should be safe I think, there should not be any other distributions out there that use libexec and have an executable Xorg in there. (centos7 does not)

OK, great.

As for the other issue, I guess we can only wait for the fix to get pushed?
(will try it in a VM tomorrow)

Yes; I actually think that xorg-x11-server-1.17.1-12 will fix the issue, which is making its way to the updates repos.

@totaam
Copy link
Collaborator Author

totaam commented May 26, 2015

2015-05-26 18:24:56: jonathan.underwood changed status from assigned to closed

@totaam
Copy link
Collaborator Author

totaam commented May 26, 2015

2015-05-26 18:24:56: jonathan.underwood set resolution to fixed

@totaam
Copy link
Collaborator Author

totaam commented May 26, 2015

2015-05-26 18:24:56: jonathan.underwood commented


Confirmed, with the patch in this bug, and xorg-x11-server-1.17.1-12, xpra now starts successfully on F22. I'll close this. Thanks for applying the patch.

@totaam totaam closed this as completed May 26, 2015
@totaam totaam added the v0.14.x label Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant