Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/*: Implement proposal 11-error-handling #109

Merged
merged 9 commits into from
Feb 18, 2020

Conversation

Xuanwo
Copy link
Contributor

@Xuanwo Xuanwo commented Feb 18, 2020

Signed-off-by: Xuanwo github@xuanwo.io

@codecov
Copy link

codecov bot commented Feb 18, 2020

Codecov Report

Merging #109 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
+ Coverage   83.35%   83.40%   +0.05%     
==========================================
  Files          12       12              
  Lines         907      898       -9     
==========================================
- Hits          756      749       -7     
+ Misses         99       97       -2     
  Partials       52       52              
Impacted Files Coverage Δ
pkg/segment/segment.go 92.30% <0.00%> (+3.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b17b36...0c0e3c4. Read the comment docs.

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo force-pushed the feature/implement_error_handle branch from 6fb9c06 to 33c5fb3 Compare February 18, 2020 00:42
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo force-pushed the feature/implement_error_handle branch from d492b39 to be7aeac Compare February 18, 2020 21:57
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo changed the title *: Implement proposal 11-error-handling pkg: Implement proposal 11-error-handling Feb 18, 2020
@Xuanwo Xuanwo changed the title pkg: Implement proposal 11-error-handling pkg/*: Implement proposal 11-error-handling Feb 18, 2020
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Contributor Author

Xuanwo commented Feb 18, 2020

codecov/patch CI doesn't pass because code deletion in pkg/segment, let's ignore.

ref: https://codecov.io/gh/Xuanwo/storage/compare/533aa99e0c7732cdbf15c205d9f9e41da4a6817d...384b23ae3f90e5102e85fdbee988fafbccdaea73/changes#D1-x8...x16

@Xuanwo Xuanwo merged commit 0864f88 into master Feb 18, 2020
@Xuanwo Xuanwo deleted the feature/implement_error_handle branch February 18, 2020 22:23
JinnyYi pushed a commit that referenced this pull request Jul 9, 2021
* Proposal: Redesign Features

Signed-off-by: Xuanwo <github@xuanwo.io>

* Assign numbers

Signed-off-by: Xuanwo <github@xuanwo.io>

* Add more details

Signed-off-by: Xuanwo <github@xuanwo.io>

* address comment

Signed-off-by: Xuanwo <github@xuanwo.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant