Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/qingstor: Implment proposal 11-error-handling #117

Merged
merged 2 commits into from
Feb 19, 2020

Conversation

Xuanwo
Copy link
Contributor

@Xuanwo Xuanwo commented Feb 18, 2020

ref: #118

Signed-off-by: Xuanwo github@xuanwo.io

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@codecov
Copy link

codecov bot commented Feb 19, 2020

Codecov Report

Merging #117 into master will increase coverage by 1.3%.
The diff coverage is 71.09%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #117     +/-   ##
=========================================
+ Coverage    83.4%   84.71%   +1.3%     
=========================================
  Files          12       12             
  Lines         898      942     +44     
=========================================
+ Hits          749      798     +49     
+ Misses         97       90      -7     
- Partials       52       54      +2
Impacted Files Coverage Δ
services/fs/utils.go 91.3% <100%> (ø) ⬆️
services/qingstor/utils.go 76.31% <64%> (-9.99%) ⬇️
services/qingstor/storager.go 81.41% <69.41%> (+4.41%) ⬆️
services/qingstor/servicer.go 73.72% <75.4%> (+7.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0864f88...dc9fdb3. Read the comment docs.

@Xuanwo Xuanwo changed the title services/*: Implment proposal 11-error-handling services/qingstor: Implment proposal 11-error-handling Feb 19, 2020
@Xuanwo
Copy link
Contributor Author

Xuanwo commented Feb 19, 2020

CI failed for codecov/patch — 71.09% of diff hit (target 83.4%), let's ignore it for now.

@Xuanwo Xuanwo merged commit 97161cd into master Feb 19, 2020
@Xuanwo Xuanwo deleted the feature/services_error_handle branch February 19, 2020 01:50
JinnyYi added a commit that referenced this pull request Jul 9, 2021
* Proposal: Rename Service to System as the Oppsite to Global

* Assign number

* Add migration path in Compatibility

* Update migration path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant