Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services: Fix WorkDir support missing in some services #131

Merged
merged 1 commit into from
Feb 27, 2020
Merged

Conversation

Xuanwo
Copy link
Contributor

@Xuanwo Xuanwo commented Feb 27, 2020

Signed-off-by: Xuanwo github@xuanwo.io

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo linked an issue Feb 27, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Feb 27, 2020

Codecov Report

Merging #131 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
+ Coverage   84.71%   84.72%   +0.01%     
==========================================
  Files          12       12              
  Lines         942      943       +1     
==========================================
+ Hits          798      799       +1     
  Misses         90       90              
  Partials       54       54
Impacted Files Coverage Δ
services/qingstor/servicer.go 73.94% <100%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04ff511...8e6c4d0. Read the comment docs.

@Xuanwo Xuanwo merged commit e3d00dd into master Feb 27, 2020
@Xuanwo Xuanwo deleted the fix/work_dir branch February 27, 2020 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

services: Pair work_dir seems to be ignored when new storage
1 participant