Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storager: Fix QingStor error not handled as intended #135

Merged
merged 1 commit into from
Feb 27, 2020

Conversation

Prnyself
Copy link
Member

No description provided.

@Prnyself
Copy link
Member Author

As comment in #118 mentioned, I fixed the formatError func to handle Qingstor error as intended.

@Xuanwo
Copy link
Contributor

Xuanwo commented Feb 27, 2020

Codacy Here is an overview of what got changed by this pull request:

Clones removed
==============
+ services/qingstor/storager.go  -1
         

See the complete overview on Codacy

@codecov
Copy link

codecov bot commented Feb 27, 2020

Codecov Report

Merging #135 into master will increase coverage by 0.42%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
+ Coverage   84.72%   85.15%   +0.42%     
==========================================
  Files          12       12              
  Lines         943      943              
==========================================
+ Hits          799      803       +4     
+ Misses         90       87       -3     
+ Partials       54       53       -1
Impacted Files Coverage Δ
services/qingstor/storager.go 82% <100%> (+0.58%) ⬆️
services/qingstor/utils.go 78.94% <0%> (+2.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3d00dd...70d96d8. Read the comment docs.

@Xuanwo Xuanwo merged commit 2e5118b into master Feb 27, 2020
@Xuanwo Xuanwo deleted the qingstor-error-format branch February 27, 2020 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants