Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/qingstor: Refactor work dir handler with unit tests #139

Merged
merged 2 commits into from
Feb 28, 2020

Conversation

Prnyself
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Feb 28, 2020

Codecov Report

Merging #139 into master will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
+ Coverage   85.15%   85.34%   +0.18%     
==========================================
  Files          12       12              
  Lines         943      955      +12     
==========================================
+ Hits          803      815      +12     
  Misses         87       87              
  Partials       53       53              

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07840b0...5be3800. Read the comment docs.

services/qingstor/errors.go Outdated Show resolved Hide resolved
services/qingstor/storager.go Outdated Show resolved Hide resolved
services/qingstor/storager.go Outdated Show resolved Hide resolved
services/qingstor/storager_test.go Outdated Show resolved Hide resolved
services/qingstor/servicer_test.go Outdated Show resolved Hide resolved
@Xuanwo
Copy link
Contributor

Xuanwo commented Feb 28, 2020

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- services/qingstor/servicer_test.go  2
- services/qingstor/servicer.go  1
         

Clones added
============
- services/qingstor/servicer_test.go  4
         

Clones removed
==============
+ services/qingstor/storager.go  -2
         

See the complete overview on Codacy

@Xuanwo Xuanwo changed the title qingstor: Modify storage handle work dir and add relevant unit tests services/qingstor: Refactor work dir handler with unit tests Feb 28, 2020
@Xuanwo Xuanwo merged commit c32951c into master Feb 28, 2020
@Xuanwo Xuanwo deleted the modify-work-dir branch February 28, 2020 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants