Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/fs: Implement proposal 11-error-handling #141

Merged
merged 1 commit into from
Feb 29, 2020

Conversation

Xuanwo
Copy link
Contributor

@Xuanwo Xuanwo commented Feb 29, 2020

Signed-off-by: Xuanwo github@xuanwo.io

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo mentioned this pull request Feb 29, 2020
10 tasks
@Xuanwo
Copy link
Contributor Author

Xuanwo commented Feb 29, 2020

Codacy Here is an overview of what got changed by this pull request:

Clones added
============
- services/qingstor/storager.go  7
         

Clones removed
==============
+ services/fs/utils_test.go  -1
+ services/fs/storager.go  -5
         

See the complete overview on Codacy

@codecov
Copy link

codecov bot commented Feb 29, 2020

Codecov Report

Merging #141 into master will increase coverage by 0.42%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
+ Coverage   85.54%   85.97%   +0.42%     
==========================================
  Files          12       12              
  Lines         955      984      +29     
==========================================
+ Hits          817      846      +29     
  Misses         86       86              
  Partials       52       52
Impacted Files Coverage Δ
services/qingstor/storager.go 82.11% <ø> (ø) ⬆️
services/fs/utils.go 92% <100%> (+0.69%) ⬆️
services/fs/storager.go 89.52% <88.67%> (+1.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7841ce2...3dbca49. Read the comment docs.

@Xuanwo Xuanwo merged commit 0f3ed3d into master Feb 29, 2020
@Xuanwo Xuanwo deleted the feature/fs_error_handle branch February 29, 2020 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant