Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement proposal support service init via config string #38

Merged
merged 11 commits into from
Dec 23, 2019

Conversation

Xuanwo
Copy link
Contributor

@Xuanwo Xuanwo commented Dec 23, 2019

No description provided.

@codecov
Copy link

codecov bot commented Dec 23, 2019

Codecov Report

Merging #38 into master will decrease coverage by 0.02%.
The diff coverage is 81.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
- Coverage   77.99%   77.97%   -0.03%     
==========================================
  Files           9       14       +5     
  Lines         968     1067      +99     
==========================================
+ Hits          755      832      +77     
- Misses        138      157      +19     
- Partials       75       78       +3
Impacted Files Coverage Δ
pkg/credential/static.go 100% <ø> (ø)
services/fs/meta.go 78.37% <ø> (ø)
services/qingstor/meta.go 65.53% <ø> (ø) ⬆️
pkg/endpoint/static.go 100% <100%> (ø)
pkg/credential/credential.go 100% <100%> (ø)
pkg/endpoint/endpoint.go 100% <100%> (ø)
services/fs/storager.go 92.63% <100%> (ø)
services/qingstor/utils.go 82.05% <22.22%> (-17.95%) ⬇️
services/fs/utils.go 68% <42.85%> (ø)
services/qingstor/servicer.go 61.46% <61.53%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29d5e70...3423f12. Read the comment docs.

@Xuanwo Xuanwo merged commit ddfa4bb into master Dec 23, 2019
@Xuanwo Xuanwo deleted the feature/config_string branch December 23, 2019 07:17
JinnyYi pushed a commit that referenced this pull request Jul 9, 2021
* proposal: Add service pair naming style

Signed-off-by: Xuanwo <github@xuanwo.io>

* Update file name

Signed-off-by: Xuanwo <github@xuanwo.io>

* Add exception for new operation

Signed-off-by: Xuanwo <github@xuanwo.io>

* Fix order

Signed-off-by: Xuanwo <github@xuanwo.io>

* Fix typo

Signed-off-by: Xuanwo <github@xuanwo.io>

* Add section for pair type

Signed-off-by: Xuanwo <github@xuanwo.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants