Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual toggle for dark theme #15

Closed
Slymeball opened this issue Jul 25, 2023 · 4 comments
Closed

Manual toggle for dark theme #15

Slymeball opened this issue Jul 25, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@Slymeball
Copy link

Slymeball commented Jul 25, 2023

No idea why this hasn't been reported yet, but I'd love to see a dark mode in Photon. I think its UI is beautiful, but I can't really consider using it daily without thinking "I wish this had a dark mode."

See next comment. The point still stands, however. I'd love to be able to use dark mode without having to explicitly tell the page that the system uses dark mode.

@Slymeball
Copy link
Author

Just opened this in Firefox (my default is LibreWolf, which is set up to not tell pages that the system uses light or dark mode, an attribute that can be used in fingerprinting) and saw that Photon does have a dark mode, but no toggle!

@Slymeball Slymeball changed the title Dark Mode Dark Mode (Toggle) Jul 25, 2023
@Xyphyn
Copy link
Owner

Xyphyn commented Jul 26, 2023

Tailwind kinda makes it a nightmare for a dark mode toggle without a flash of your system colors at the start. I will attempt to implement this though

@Xyphyn
Copy link
Owner

Xyphyn commented Jul 26, 2023

I'll also add a warning that "system" theme will likely be white with fingerprinting blockers

@Xyphyn Xyphyn changed the title Dark Mode (Toggle) Manual toggle for dark theme Jul 26, 2023
@Xyphyn Xyphyn added the enhancement New feature or request label Jul 26, 2023
@Xyphyn
Copy link
Owner

Xyphyn commented Aug 9, 2023

Added in v0.5.7, finally. Can be accessed from the main menu

@Xyphyn Xyphyn closed this as completed Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants