Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

u specifier won't work when player name changed #3

Closed
maddinat0r opened this issue Jun 7, 2016 · 2 comments
Closed

u specifier won't work when player name changed #3

maddinat0r opened this issue Jun 7, 2016 · 2 comments
Assignees
Labels

Comments

@maddinat0r
Copy link
Collaborator

I did not see a hook for SetPlayerName in the include, so I'm pretty sure the u/U specifiers won't work when a player name is changed (well they will work, but they'll only accept the old name, not the new one since it's not updated internally).
I also should check for the return value of SetPlayerName when implementing the hook (only when SetPlayerName returns 1 (success) the name should be updated in the plugin).

@maddinat0r maddinat0r added the bug label Jun 7, 2016
@maddinat0r maddinat0r self-assigned this Jun 7, 2016
@maddinat0r
Copy link
Collaborator Author

@maddinat0r
Copy link
Collaborator Author

...however, it does not check for SetPlayerName's return value, so someone could set §Invalid§Chars³ as name and sscanf would simply accept it, while the players name does not change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant