Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify encoding and padding #1

Merged
merged 3 commits into from Mar 11, 2022
Merged

Modify encoding and padding #1

merged 3 commits into from Mar 11, 2022

Conversation

Y4NG333
Copy link
Owner

@Y4NG333 Y4NG333 commented Mar 10, 2022

Mainly modified two parts:
1.Padding is added at the end of the 4-bit huffman character ---> padding is added at the end of the entire sequence
2.Use 1 and 2 for Huffman coding, use 0 as padding ------> Use 0 and 1 for Huffman coding

Final Results :
For a random sequence of length 10 :
C9TGM$T516 )3)V}F7RMW
The effect is very good, the sequence generated by the model is consistent with the correct sequence, but his attention map is very different from the expected.
867IFV_R%_~MJW6 CYFSU7V
It can even be said that the results of the attention map are confusing :(

Padding is added at the end of the 4-bit huffman character-->padding is added at the end of the entire sequence
Padding is added at the end of the 4-bit huffman character-->padding is added at the end of the entire sequence
Padding is added at the end of the 4-bit huffman character-->padding is added at the end of the entire sequence
@Y4NG333
Copy link
Owner Author

Y4NG333 commented Mar 11, 2022

@albert-no 교수님, 코드를 조금 수정하고 PR을 배웠습니다 :)

@albert-no
Copy link
Collaborator

@Y4NG333
네 고생많았습니다.
일단 현재 버전 merge하고 코드 수정하는 PR을 제가 다시 만들겠습니다.
그리고 commit할때 그 역할에 따라 commit의 이름을 잘 적어야합니다. 지금처럼 모든 commit이 같은 이름을 사용해서는 안됩니다.

@albert-no albert-no merged commit 582c6bc into main Mar 11, 2022
@Y4NG333
Copy link
Owner Author

Y4NG333 commented Mar 11, 2022

네, 교수님 감사합니다.다음부터는 이런 실수를 하지 않겠습니다.

@albert-no albert-no deleted the Modify_encoding branch April 18, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants