Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the code #2

Merged
merged 6 commits into from Mar 13, 2022
Merged

Refactor the code #2

merged 6 commits into from Mar 13, 2022

Conversation

albert-no
Copy link
Collaborator

@albert-no albert-no commented Mar 12, 2022 •
edited

  • 숫자 직접입력 금지. (예를 들어 self.d_k = 64 와 같이 하지말고 d_k를 입력으로 받기. 해당 부분 추가로 수정)
  • for문 쓰지 않는법 연습 (코드 확인)
  • prettier대신 black사용하기
  • 그림그리는 코드 utils.py에서 완성
  • rotate도 직접 작성하지 말고 해당 기능을 수행하는 함수가 있는지 확인

@Y4NG333
Copy link
Owner

Y4NG333 commented Mar 12, 2022

네, 현재 변경사항이 확인되었습니다 : )

@albert-no
Copy link
Collaborator Author

albert-no commented Mar 13, 2022 •
edited

@Y4NG333 위 코멘트를 참고하여 코드 바뀐부분을 확인해보기 바랍니다.
확인이 완료되면 이 PR을 merge하고 새로운 PR을 열어서 마저 수정하도록 하기바랍니다.

@Y4NG333
Copy link
Owner

Y4NG333 commented Mar 13, 2022

네, 교수님, 코드 바뀐부분을 확인하고 있습니다 .

@Y4NG333 Y4NG333 merged commit e239143 into main Mar 13, 2022
@albert-no albert-no deleted the refactor branch April 18, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@albert-no @Y4NG333