Skip to content

Commit

Permalink
ACPI: processor: refactor internal map_lapic_id()
Browse files Browse the repository at this point in the history
Untangle the if() statement a little for readability.

Acked-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Signed-off-by: Alex Chiang <achiang@hp.com>
Signed-off-by: Len Brown <len.brown@intel.com>
  • Loading branch information
Alex Chiang authored and lenb committed Mar 15, 2010
1 parent d8191fa commit 1113073
Showing 1 changed file with 9 additions and 6 deletions.
15 changes: 9 additions & 6 deletions drivers/acpi/processor_core.c
Expand Up @@ -50,12 +50,15 @@ static int map_lapic_id(struct acpi_subtable_header *entry,
{
struct acpi_madt_local_apic *lapic =
(struct acpi_madt_local_apic *)entry;
if ((lapic->lapic_flags & ACPI_MADT_ENABLED) &&
lapic->processor_id == acpi_id) {
*apic_id = lapic->id;
return 1;
}
return 0;

if (!(lapic->lapic_flags & ACPI_MADT_ENABLED))
return 0;

if (lapic->processor_id != acpi_id)
return 0;

*apic_id = lapic->id;
return 1;
}

static int map_x2apic_id(struct acpi_subtable_header *entry,
Expand Down

0 comments on commit 1113073

Please sign in to comment.