Skip to content

Commit

Permalink
rtc-vr41xx: fix do_div() warning
Browse files Browse the repository at this point in the history
drivers/rtc/rtc-vr41xx.c: In function 'vr41xx_rtc_irq_set_freq':
drivers/rtc/rtc-vr41xx.c:217: warning: comparison of distinct pointer types lacks a cast
drivers/rtc/rtc-vr41xx.c:217: warning: right shift count >= width of type
drivers/rtc/rtc-vr41xx.c:217: warning: passing argument 1 of '__div64_32' from incompatible pointer type
include/asm-generic/div64.h:35: note: expected 'uint64_t *' but argument is of type 'long unsigned int *'

Signed-off-by: Yoichi Yuasa <yuasa@linux-mips.org>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Paul Gortmaker <p_gortmaker@yahoo.com>
Cc: Paul Mundt <lethal@linux-sh.org>
Cc: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Yoichi Yuasa authored and torvalds committed Nov 12, 2009
1 parent fc63cf2 commit 61df333
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions drivers/rtc/rtc-vr41xx.c
Expand Up @@ -209,19 +209,18 @@ static int vr41xx_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *wkalrm)

static int vr41xx_rtc_irq_set_freq(struct device *dev, int freq)
{
unsigned long count;
u64 count;

if (!is_power_of_2(freq))
return -EINVAL;
count = RTC_FREQUENCY;
do_div(count, freq);

periodic_count = count;

spin_lock_irq(&rtc_lock);

rtc1_write(RTCL1LREG, count);
rtc1_write(RTCL1HREG, count >> 16);
periodic_count = count;
rtc1_write(RTCL1LREG, periodic_count);
rtc1_write(RTCL1HREG, periodic_count >> 16);

spin_unlock_irq(&rtc_lock);

Expand Down

0 comments on commit 61df333

Please sign in to comment.