Skip to content

Commit

Permalink
x86, ioapic: Don't warn about non-existing IOAPICs if we have none
Browse files Browse the repository at this point in the history
mp_find_ioapic() prints errors like:

    ERROR: Unable to locate IOAPIC for GSI 13

if it can't find the IOAPIC that manages that specific GSI. I
see errors like that at every boot of a laptop that apparently
doesn't have any IOAPICs.

But if there are no IOAPICs it doesn't seem to be an error that
none can be found. A solution that gets rid of this message is
to directly return if nr_ioapics (still) is zero. (But keep
returning -1 in that case, so nothing breaks from this change.)

The call chain that generates this error is:

pnpacpi_allocated_resource()
    case ACPI_RESOURCE_TYPE_IRQ:
        pnpacpi_parse_allocated_irqresource()
            acpi_get_override_irq()
                 mp_find_ioapic()

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
pebolle authored and Ingo Molnar committed Feb 15, 2011
1 parent 1c9d16e commit 678301e
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions arch/x86/kernel/apic/io_apic.c
Expand Up @@ -4002,6 +4002,9 @@ int mp_find_ioapic(u32 gsi)
{
int i = 0;

if (nr_ioapics == 0)
return -1;

/* Find the IOAPIC that manages this GSI. */
for (i = 0; i < nr_ioapics; i++) {
if ((gsi >= mp_gsi_routing[i].gsi_base)
Expand Down

0 comments on commit 678301e

Please sign in to comment.