Skip to content

Commit

Permalink
ieee1394: fix oops on "modprobe -r ohci1394" after network class_devi…
Browse files Browse the repository at this point in the history
…ce conversion

The networking subsystem has been converted from class_device to device
but ieee1394 hasn't.  This results in a 100% reproducible NULL pointer
dereference if the ohci1394 driver module is unloaded while the eth1394
module is still loaded.
http://lkml.org/lkml/2006/11/16/147
http://lkml.org/lkml/2007/3/14/4

This is a regression in 2.6.21-rc1.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Tested-by: Ismail Dönmez <ismail@pardus.org.tr>
  • Loading branch information
Stefan Richter committed Mar 23, 2007
1 parent 1299809 commit 7a9eeb2
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/ieee1394/eth1394.c
Expand Up @@ -584,7 +584,10 @@ static void ether1394_add_host (struct hpsb_host *host)
}

SET_MODULE_OWNER(dev);
#if 0
/* FIXME - Is this the correct parent device anyway? */
SET_NETDEV_DEV(dev, &host->device);
#endif

priv = netdev_priv(dev);

Expand Down

0 comments on commit 7a9eeb2

Please sign in to comment.