Skip to content

Commit

Permalink
hwmon: (adt7475) Fix temperature fault flags
Browse files Browse the repository at this point in the history
The logic of temperature fault flags is wrong, it shows faults when
there are none and vice versa. Fix it.

I can't believe this has been broken since the driver was added, 8
months ago, basically breaking temp1 and temp3, and nobody ever
complained.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Acked-by: Hans de Goede <hdegoede@redhat.com>
Cc: Jordan Crouse <jordan@cosmicpenguin.net>
  • Loading branch information
Jean Delvare committed Nov 16, 2009
1 parent be4c23c commit cf312e0
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/hwmon/adt7475.c
Expand Up @@ -350,8 +350,7 @@ static ssize_t show_temp(struct device *dev, struct device_attribute *attr,

case FAULT:
/* Note - only for remote1 and remote2 */
out = data->alarms & (sattr->index ? 0x8000 : 0x4000);
out = out ? 0 : 1;
out = !!(data->alarms & (sattr->index ? 0x8000 : 0x4000));
break;

default:
Expand Down

0 comments on commit cf312e0

Please sign in to comment.