Skip to content

Commit

Permalink
Dont touch fs_struct in usermodehelper
Browse files Browse the repository at this point in the history
This test seems to be unnecessary since we always have rootfs mounted before
calling a usermodehelper.

Signed-off-by: Andreas Gruenbacher <agruen@suse.de>
Signed-off-by: Jan Blunck <jblunck@suse.de>
Acked-by: Christoph Hellwig <hch@lst.de>
Acked-by: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Jan Blunck authored and Linus Torvalds committed Feb 15, 2008
1 parent 0d63e4f commit db74ece
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions kernel/kmod.c
Expand Up @@ -173,10 +173,7 @@ static int ____call_usermodehelper(void *data)
*/
set_user_nice(current, 0);

retval = -EPERM;
if (current->fs->root)
retval = kernel_execve(sub_info->path,
sub_info->argv, sub_info->envp);
retval = kernel_execve(sub_info->path, sub_info->argv, sub_info->envp);

/* Exec failed? */
sub_info->retval = retval;
Expand Down

0 comments on commit db74ece

Please sign in to comment.