Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is the weighted combination of estimated input image ( \hat(x0) ) and noisy image (x_t) used? #5

Open
hemanth2090 opened this issue Aug 8, 2023 · 2 comments

Comments

@hemanth2090
Copy link

Hello,

Your paper is very interesting. Thank you for sharing your code. I have a question regarding Line 218 in image_editor_zecon.py file
https://github.com/YSerin/ZeCon/blob/51e679ef49d3875893eb956411abc802d9d8fc4c/optimization/image_editor_zecon.py#L218C1-L219C1

From what I understand, out['pred_xstart'] is \hat(x_0(x_t)). Since we have x0 available, the loss can be computed between out['pred_xstart'] and x0. Why have you taken a weighted combination in Line 218 to obtain x_t and y_t before computing the loss.

Also, could you please point me to the part of the paper that discusses the formulation of the 'fac' term in line 218.

regards,
hemanth

@kothari1997narayan
Copy link

+1
I also have the same question..
Please let us know..
Thanks..

@Xiaoda-Zhong
Copy link

Same question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants