Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests for tourbook import/export function #390

Open
chrgernoe opened this issue Jan 11, 2023 · 3 comments
Open

Unit tests for tourbook import/export function #390

chrgernoe opened this issue Jan 11, 2023 · 3 comments
Labels
KTLO This feature will not be delivered to customers
Projects
YacGuide
Milestone
v0.8.0

Comments

@chrgernoe
Copy link
Member

chrgernoe commented Jan 11, 2023 •
edited
Loading

Can be started after #388 is merged.

Add tests for classes:

  • JsonImporter
  • JsonExporter
  • CvsExporter
  • TourbookExporterFactory
@chrgernoe chrgernoe added the KTLO This feature will not be delivered to customers label Jan 11, 2023
@chrgernoe chrgernoe added this to the v0.7.0 milestone Jan 11, 2023
@chrgernoe chrgernoe added this to To do in YacGuide via automation Jan 11, 2023
@chrgernoe chrgernoe mentioned this issue Jan 11, 2023
Merged
@paetz paetz removed this from the v0.7.0 milestone Jan 11, 2023
@paetz
Copy link
Collaborator

paetz commented Jan 11, 2023 •
edited
Loading

Correct me if I'm wrong but since we derive the What'sNew info from the issues that are tagged with the current milestone, we should not tag test issues with a milestone. The user does not need (and does not want) to know anything about tests e.g.
The user is interested in features and of course, a delivered feature counts as fully-tested for the user :)

@chrgernoe
Copy link
Member Author

No, we don't derive it from there. We just take all PRs since the last release. Since I write the official What's New in German, I anyway go through all the issues and sort-out KTLO issues.
I tagged the issue with v0.7.0, so that we don't forget it.

@paetz
Copy link
Collaborator

paetz commented Jan 12, 2023 •
edited
Loading

Ok then it's fine. However, we also have the priority label if you want to emphasize an issues's importance.

@paetz paetz added this to the v0.8.0 milestone Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
KTLO This feature will not be delivered to customers
Projects
YacGuide
  
To do
Milestone
v0.8.0
Development

No branches or pull requests
2 participants
@chrgernoe @paetz