Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel region update immediately on error #404

Open
paetz opened this issue Feb 11, 2023 · 0 comments
Open

Cancel region update immediately on error #404

paetz opened this issue Feb 11, 2023 · 0 comments
Labels
feature New feature or request
Projects
Milestone

Comments

@paetz
Copy link
Collaborator

paetz commented Feb 11, 2023

Current update behavior is like this:
If an error occurs, do not parse anymore but wait for all network requests to be executed.

It would be more efficient to cancel the network threads on error immediately.
Possible problems:

  • Can we cancel a coroutine from inside?
  • Cancelling a coroutine just sends a cancel request to the threads. It might be possible that the receiving & enqueuing coroutines still work for the old region while a new region's update has already been started (in case of "Update all")
@paetz paetz added the feature New feature or request label Feb 11, 2023
@paetz paetz added this to To do in YacGuide via automation Feb 11, 2023
@paetz paetz added this to the v0.8.0 milestone Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
YacGuide
  
To do
Development

No branches or pull requests

1 participant