Add translation pipeline model #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 9, 2021 21:32
|
still TODO: add this new model to the documentation |
|
@niansong1996 should be ready for review now! |
README.md
Outdated
| @@ -87,6 +87,7 @@ SummerTime supports different models (e.g., TextRank, BART, Longformer) as well | |||
| | LongformerModel | :heavy_check_mark: | | | | | | |||
| | MBartModel | :heavy_check_mark: | | | | 50 languages (Arabic, Czech, German, English, Spanish, Estonian, Finnish, French, Gujarati, Hindi, Italian, Japanese, Kazakh, Korean, Lithuanian, Latvian, Burmese, Nepali, Dutch, Romanian, Russian, Sinhala, Turkish, Vietnamese, Chinese, Afrikaans, Azerbaijani, Bengali, Persian, Hebrew, Croatian, Indonesian, Georgian, Khmer, Macedonian, Malayalam, Mongolian, Marathi, Polish, Pashto, Portuguese, Swedish, Tamil, Telugu, Thai, Tagalog, Ukrainian, Urdu, Xhosa, Slovenian) | | |||
There was a problem hiding this comment.
For the languages, maybe compile a list and only put a link here to that list?
| ) | ||
| # TODO: translate each doc separately if provided multiple docs in corpus? | ||
| if queries: | ||
| queries = self.translator.translate(queries, target_lang="en", beam_size=4) |
There was a problem hiding this comment.
when you specify the beam_size as 4, is the output one sentence or 4?
There was a problem hiding this comment.
Still just one sentence -- this is just the beam size for the translation model's generation.
|
All set with the changes! (assuming you were referring to the mBART-50 listed languages in the README) |
|
LGTM, merging now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a translation pipeline model class (other lang -> translate to english -> summarization in english -> translate summaries to english)
Addressing #109