/
handlers_buckets.go
486 lines (425 loc) · 14.1 KB
/
handlers_buckets.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
package api
import (
"encoding/json"
"fmt"
"net/http"
"strings"
"time"
"github.com/YaleSpinup/apierror"
"github.com/aws/aws-sdk-go/aws"
"github.com/aws/aws-sdk-go/service/iam"
"github.com/aws/aws-sdk-go/service/s3"
"github.com/gorilla/mux"
"github.com/pkg/errors"
log "github.com/sirupsen/logrus"
)
// BucketCreateHandler orchestrates the creation of a new s3 bucket with rollback in the event of
// failure. The operations are
// 1. create the bucket with the given name
// 2. tag the bucket with given tags
// 3. generate the default admin bucket policy
// 4. create the admin bucket policy
// 5. create the bucket admin group, '<bucketName>-BktAdmGrp'
// 6. attach the bucket admin policy to the bucket admin group
// Note: this does _not_ create any users for managing the bucket
func (s *server) BucketCreateHandler(w http.ResponseWriter, r *http.Request) {
w = LogWriter{w}
vars := mux.Vars(r)
account := vars["account"]
s3Service, ok := s.s3Services[account]
if !ok {
msg := fmt.Sprintf("s3 service not found for account: %s", account)
handleError(w, apierror.New(apierror.ErrNotFound, msg, nil))
return
}
iamService, ok := s.iamServices[account]
if !ok {
msg := fmt.Sprintf("IAM service not found for account: %s", account)
handleError(w, apierror.New(apierror.ErrNotFound, msg, nil))
return
}
var req struct {
Tags []*s3.Tag
BucketInput s3.CreateBucketInput
}
err := json.NewDecoder(r.Body).Decode(&req)
if err != nil {
msg := fmt.Sprintf("cannot decode body into create bucket input: %s", err)
handleError(w, apierror.New(apierror.ErrBadRequest, msg, err))
return
}
// append org tag that will get applied to all resources that tag
req.Tags = append(req.Tags, &s3.Tag{
Key: aws.String("spinup:org"),
Value: aws.String(Org),
})
// setup err var, rollback function list and defer execution, note that we depend on the err variable defined above this
var rollBackTasks []func() error
defer func() {
if err != nil {
log.Errorf("recovering from error: %s, executing %d rollback tasks", err, len(rollBackTasks))
rollBack(&rollBackTasks)
}
}()
bucketName := aws.StringValue(req.BucketInput.Bucket)
bucketOutput, err := s3Service.CreateBucket(r.Context(), &req.BucketInput)
if err != nil {
msg := fmt.Sprintf("failed to create bucket: %s", err)
handleError(w, errors.Wrap(err, msg))
return
}
// append bucket delete to rollback tasks
rbfunc := func() error {
return func() error {
if err := s3Service.DeleteEmptyBucket(r.Context(), &s3.DeleteBucketInput{Bucket: aws.String(bucketName)}); err != nil {
return err
}
return nil
}()
}
rollBackTasks = append(rollBackTasks, rbfunc)
// wait for the bucket to exist
err = retry(3, 2*time.Second, func() error {
log.Infof("checking if bucket exists before continuing: %s", bucketName)
exists, err := s3Service.BucketExists(r.Context(), bucketName)
if err != nil {
return err
}
if exists {
log.Infof("bucket %s exists", bucketName)
return nil
}
msg := fmt.Sprintf("s3 bucket (%s) doesn't exist", bucketName)
return errors.New(msg)
})
if err != nil {
msg := fmt.Sprintf("failed to create bucket %s, timeout waiting for create: %s", bucketName, err.Error())
handleError(w, errors.Wrap(err, msg))
return
}
err = s3Service.TagBucket(r.Context(), bucketName, req.Tags)
if err != nil {
msg := fmt.Sprintf("failed to tag bucket %s: %s", bucketName, err.Error())
handleError(w, errors.Wrap(err, msg))
return
}
// enable AWS managed serverside encryption for the bucket
err = s3Service.UpdateBucketEncryption(r.Context(), &s3.PutBucketEncryptionInput{
Bucket: aws.String(bucketName),
ServerSideEncryptionConfiguration: &s3.ServerSideEncryptionConfiguration{
Rules: []*s3.ServerSideEncryptionRule{
{
ApplyServerSideEncryptionByDefault: &s3.ServerSideEncryptionByDefault{
SSEAlgorithm: aws.String("AES256"),
},
},
},
},
})
if err != nil {
msg := fmt.Sprintf("failed to enable encryption for bucket %s: %s", bucketName, err.Error())
handleError(w, errors.Wrap(err, msg))
return
}
// enable logging access for the bucket to a central repo if the target bucket is set
if s3Service.LoggingBucket != "" {
err = s3Service.UpdateBucketLogging(r.Context(), bucketName, s3Service.LoggingBucket, s3Service.LoggingBucketPrefix)
if err != nil {
msg := fmt.Sprintf("failed to enable logging for bucket %s: %s", bucketName, err.Error())
handleError(w, errors.Wrap(err, msg))
return
}
}
// build the default IAM bucket admin policy (from the config and known inputs)
defaultPolicy, err := iamService.DefaultBucketAdminPolicy(aws.String(bucketName))
if err != nil {
msg := fmt.Sprintf("failed creating default IAM policy for bucket %s: %s", bucketName, err.Error())
handleError(w, errors.Wrap(err, msg))
return
}
policyOutput, err := iamService.CreatePolicy(r.Context(), &iam.CreatePolicyInput{
Description: aws.String(fmt.Sprintf("Admin policy for %s bucket", bucketName)),
PolicyDocument: aws.String(string(defaultPolicy)),
PolicyName: aws.String(fmt.Sprintf("%s-BktAdmPlc", bucketName)),
})
if err != nil {
msg := fmt.Sprintf("failed to create policy: %s", err.Error())
handleError(w, errors.Wrap(err, msg))
return
}
// append policy delete to rollback tasks
rbfunc = func() error {
return func() error {
if _, err := iamService.DeletePolicy(r.Context(), &iam.DeletePolicyInput{PolicyArn: policyOutput.Policy.Arn}); err != nil {
return err
}
return nil
}()
}
rollBackTasks = append(rollBackTasks, rbfunc)
groupName := fmt.Sprintf("%s-BktAdmGrp", bucketName)
group, err := iamService.CreateGroup(r.Context(), &iam.CreateGroupInput{
GroupName: aws.String(groupName),
})
if err != nil {
msg := fmt.Sprintf("failed to create group: %s", err.Error())
handleError(w, errors.Wrap(err, msg))
return
}
// append group delete to rollback tasks
rbfunc = func() error {
return func() error {
if _, err := iamService.DeleteGroup(r.Context(), &iam.DeleteGroupInput{GroupName: aws.String(groupName)}); err != nil {
return err
}
return nil
}()
}
rollBackTasks = append(rollBackTasks, rbfunc)
if _, err = iamService.AttachGroupPolicy(r.Context(), &iam.AttachGroupPolicyInput{
GroupName: aws.String(groupName),
PolicyArn: policyOutput.Policy.Arn,
}); err != nil {
msg := fmt.Sprintf("failed to create group: %s", err.Error())
handleError(w, errors.Wrap(err, msg))
return
}
output := struct {
Bucket *string
Policy *iam.Policy
Group *iam.Group
}{
bucketOutput.Location,
policyOutput.Policy,
group.Group,
}
j, err := json.Marshal(output)
if err != nil {
log.Errorf("cannot marshal reasponse(%v) into JSON: %s", output, err)
w.WriteHeader(http.StatusInternalServerError)
return
}
w.Header().Set("Content-Type", "application/json")
w.WriteHeader(http.StatusOK)
w.Write(j)
}
// BucketListHandler gets a list of all buckets in the account
func (s *server) BucketListHandler(w http.ResponseWriter, r *http.Request) {
w = LogWriter{w}
vars := mux.Vars(r)
account := vars["account"]
s3Service, ok := s.s3Services[account]
if !ok {
log.Errorf("account not found: %s", account)
w.WriteHeader(http.StatusNotFound)
return
}
output, err := s3Service.ListBuckets(r.Context(), &s3.ListBucketsInput{})
if err != nil {
handleError(w, err)
return
}
buckets := []string{}
for _, b := range output {
buckets = append(buckets, aws.StringValue(b.Name))
}
j, err := json.Marshal(buckets)
if err != nil {
log.Errorf("cannot marshal response (%v) into JSON: %s", buckets, err)
w.WriteHeader(http.StatusInternalServerError)
return
}
w.Header().Set("Content-Type", "application/json")
w.WriteHeader(http.StatusOK)
w.Write(j)
}
// BucketHeadHandler checks if a bucket exists
func (s *server) BucketHeadHandler(w http.ResponseWriter, r *http.Request) {
w = LogWriter{w}
vars := mux.Vars(r)
account := vars["account"]
bucket := vars["bucket"]
s3Service, ok := s.s3Services[account]
if !ok {
log.Errorf("account not found: %s", account)
w.WriteHeader(http.StatusNotFound)
return
}
log.Infof("checking if bucket exists: %s", bucket)
exists, err := s3Service.BucketExists(r.Context(), bucket)
if err != nil {
handleError(w, err)
return
}
if !exists {
w.WriteHeader(http.StatusNotFound)
w.Write([]byte{})
}
w.WriteHeader(http.StatusOK)
w.Write([]byte{})
}
// BucketDeleteHandler deletes an empty bucket and all of it's dependencies. The operations are
// 1. the bucket is deleted, this will fail if the bucket is not empty
// 2. a list of policies attached to the bucket admin group (<bucketName>-BktAdmGrp) is gathered
// 3. each of those policies is detached from the group and if it starts with '<bucketName>-', it is deleted
// 4. the bucket admin group is deleted
func (s *server) BucketDeleteHandler(w http.ResponseWriter, r *http.Request) {
w = LogWriter{w}
vars := mux.Vars(r)
account := vars["account"]
bucket := vars["bucket"]
s3Service, ok := s.s3Services[account]
if !ok {
log.Errorf("account not found: %s", account)
w.WriteHeader(http.StatusNotFound)
return
}
iamService, ok := s.iamServices[account]
if !ok {
msg := fmt.Sprintf("IAM service not found for account: %s", account)
handleError(w, apierror.New(apierror.ErrNotFound, msg, nil))
return
}
err := s3Service.DeleteEmptyBucket(r.Context(), &s3.DeleteBucketInput{Bucket: aws.String(bucket)})
if err != nil {
handleError(w, err)
return
}
w.Header().Set("Content-Type", "application/json")
w.WriteHeader(http.StatusOK)
// TODO: if this fails with a NotFound, we should continue on because its probably a legacy bucket
groupName := fmt.Sprintf("%s-BktAdmGrp", bucket)
policies, err := iamService.ListGroupPolicies(r.Context(), &iam.ListAttachedGroupPoliciesInput{GroupName: aws.String(groupName)})
if err != nil {
log.Warnf("failed to list group policies when deleting bucket %s: %s", bucket, err)
j, _ := json.Marshal("failed to list group policies: " + err.Error())
w.Write(j)
}
for _, p := range policies {
if err := iamService.DetachGroupPolicy(r.Context(), &iam.DetachGroupPolicyInput{
GroupName: aws.String(groupName),
PolicyArn: p.PolicyArn,
}); err != nil {
log.Warnf("failed to detach policy %s from group %s when deleting bucket %s: %s", aws.StringValue(p.PolicyArn), groupName, bucket, err)
j, _ := json.Marshal("failed to detatch group policy: " + err.Error())
w.Write(j)
return
}
if strings.HasPrefix(aws.StringValue(p.PolicyName), bucket+"-") {
if _, err := iamService.DeletePolicy(r.Context(), &iam.DeletePolicyInput{PolicyArn: p.PolicyArn}); err != nil {
log.Warnf("failed to delete group policy %s when deleting bucket %s: %s", aws.StringValue(p.PolicyArn), bucket, err)
j, _ := json.Marshal("failed to delete group policy: " + err.Error())
w.Write(j)
return
}
break
}
}
users, err := iamService.ListGroupUsers(r.Context(), &iam.GetGroupInput{GroupName: aws.String(groupName)})
if err != nil {
log.Warnf("failed to list group's users when deleting bucket %s: %s", bucket, err)
j, _ := json.Marshal("failed to list group users: " + err.Error())
w.Write(j)
}
for _, u := range users {
if err := iamService.RemoveUserFromGroup(r.Context(), &iam.RemoveUserFromGroupInput{UserName: u.UserName, GroupName: aws.String(groupName)}); err != nil {
log.Warnf("failed to remove user %s from group %s when deleting bucket %s: %s", aws.StringValue(u.UserName), groupName, bucket, err)
j, _ := json.Marshal("failed to remove user from group group: " + err.Error())
w.Write(j)
return
}
}
if _, err := iamService.DeleteGroup(r.Context(), &iam.DeleteGroupInput{GroupName: aws.String(groupName)}); err != nil {
log.Warnf("failed to delete group %s when deleting bucket %s: %s", groupName, bucket, err)
j, _ := json.Marshal("failed to delete group: " + err.Error())
w.Write(j)
return
}
w.Write([]byte{})
}
// BucketShowHandler returns information about a bucket
func (s *server) BucketShowHandler(w http.ResponseWriter, r *http.Request) {
w = LogWriter{w}
vars := mux.Vars(r)
account := vars["account"]
bucket := vars["bucket"]
s3Service, ok := s.s3Services[account]
if !ok {
log.Errorf("account not found: %s", account)
w.WriteHeader(http.StatusNotFound)
return
}
tags, err := s3Service.GetBucketTags(r.Context(), bucket)
if err != nil {
handleError(w, err)
return
}
empty, err := s3Service.BucketEmpty(r.Context(), bucket)
if err != nil {
handleError(w, err)
return
}
logging, err := s3Service.GetBucketLogging(r.Context(), bucket)
if err != nil {
handleError(w, err)
return
}
// setup output struct
output := struct {
Tags []*s3.Tag
Logging *s3.LoggingEnabled
Empty bool
}{
Tags: tags,
Logging: logging,
Empty: empty,
}
j, err := json.Marshal(output)
if err != nil {
log.Errorf("cannot marshal response (%v) into JSON: %s", output, err)
w.WriteHeader(http.StatusInternalServerError)
return
}
w.Header().Set("Content-Type", "application/json")
w.WriteHeader(http.StatusOK)
w.Write(j)
}
// BucketUpdateHandler handles updating making changes to a bucket. Currently supports:
// - Updating the bucket's tags
func (s *server) BucketUpdateHandler(w http.ResponseWriter, r *http.Request) {
w = LogWriter{w}
vars := mux.Vars(r)
account := vars["account"]
bucket := vars["bucket"]
s3Service, ok := s.s3Services[account]
if !ok {
msg := fmt.Sprintf("s3 service not found for account: %s", account)
handleError(w, apierror.New(apierror.ErrNotFound, msg, nil))
return
}
var req struct {
Tags []*s3.Tag
}
err := json.NewDecoder(r.Body).Decode(&req)
if err != nil {
msg := fmt.Sprintf("cannot decode body into update bucket input: %s", err)
handleError(w, apierror.New(apierror.ErrBadRequest, msg, err))
return
}
// append org tag that will get applied to all resources that tag
req.Tags = append(req.Tags, &s3.Tag{
Key: aws.String("spinup:org"),
Value: aws.String(Org),
})
if len(req.Tags) > 0 {
err = s3Service.TagBucket(r.Context(), bucket, req.Tags)
if err != nil {
msg := fmt.Sprintf("failed to tag bucket %s: %s", bucket, err.Error())
handleError(w, apierror.New(apierror.ErrInternalError, msg, err))
return
}
}
w.Header().Set("Content-Type", "application/json")
w.WriteHeader(http.StatusOK)
w.Write([]byte{})
}