Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build runner-images from main branch instead of release #84

Open
robbert-nlo opened this issue May 6, 2024 · 5 comments
Open

Build runner-images from main branch instead of release #84

robbert-nlo opened this issue May 6, 2024 · 5 comments

Comments

@robbert-nlo
Copy link
Contributor

Hi Yannick,

I noticed my builds were failing and tracked it down to this upstream issue: actions/runner-images#9742. This issue appears to be fixed upstream for 2 weeks already, however my build still fails because this repo uses release tags to checkout the upstream repo. Apparently, according to this comment and the last faq question on this page, that is against upstream advise.

Could you consider following upstream advise on this and start building using the main branch of the runner-images repo?

Thanks,
Robbert

@YannickRe
Copy link
Owner

We only use release tags when you go "pre-release" or "release", if you want to follow recommendation from upstream then you have to select "alpha":
image

That should cover your request 😆

@robbert-nlo
Copy link
Contributor Author

@YannickRe I see. Shouldn't this be the default in that case, since it is upstream recommended? Right now, the default is 'release'.

@YannickRe
Copy link
Owner

Objectively: yes. But it will be a behavioral breaking change which we need to be careful with.
Additionally, most users of this repo have their own “base” pipeline with their own input parameters, config values for agent pools etc and those users can set their own defaults for this parameter.

@robbert-nlo
Copy link
Contributor Author

@YannickRe I understand. The thing is, I'm running this pipeline automatically and this input parameter cannot be configured from the variable group, so that leaves me with having to patch your code. I rather avoid/minimize manual patching to stay compatible with you as upstream.

@robbert-nlo
Copy link
Contributor Author

@YannickRe I just reread your comment, and I now understand you mean most users are using a customized buildagent-generation.yml with adjusted settings. I'll start doing that too.

Two comments however:

  1. The fact that most users are using a customized yml is not really a strong argument against changing the default version to match upstream's recommendation. In fact, it actually limits the impact of changing the default since not a lot of people will be using the vanilla buildagent-generation.yml file.
  2. It would be nice if the defaults could be sourced from env vars / DevOps Variable Group. That way, the use of a customized yml could be avoided altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants