-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build runner-images from main branch instead of release #84
Comments
@YannickRe I see. Shouldn't this be the default in that case, since it is upstream recommended? Right now, the default is 'release'. |
Objectively: yes. But it will be a behavioral breaking change which we need to be careful with. |
@YannickRe I understand. The thing is, I'm running this pipeline automatically and this input parameter cannot be configured from the variable group, so that leaves me with having to patch your code. I rather avoid/minimize manual patching to stay compatible with you as upstream. |
@YannickRe I just reread your comment, and I now understand you mean most users are using a customized Two comments however:
|
Hi Yannick,
I noticed my builds were failing and tracked it down to this upstream issue: actions/runner-images#9742. This issue appears to be fixed upstream for 2 weeks already, however my build still fails because this repo uses release tags to checkout the upstream repo. Apparently, according to this comment and the last faq question on this page, that is against upstream advise.
Could you consider following upstream advise on this and start building using the main branch of the runner-images repo?
Thanks,
Robbert
The text was updated successfully, but these errors were encountered: