Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework github actions #135

Open
YarikTH opened this issue Sep 7, 2023 · 0 comments
Open

Rework github actions #135

YarikTH opened this issue Sep 7, 2023 · 0 comments

Comments

@YarikTH
Copy link
Owner

YarikTH commented Sep 7, 2023

Description

Current scheme works fine, but there is place for improvement.

It seems that current approach of binding all the builds in the single matrix works not so good as I thought. It allows to reduce duplication, but cost is - less flexibility and ugly actions summary.

Current single matrix approach:
image

nlohmann/json approach:
image

Second is nice and clean. But has a lot of repetitions in yaml that I assume fixable with yaml's subtree substitutions.

I think it's better to mimic nlohmann/json build configurations as much as it makes sense. They have good middle ground between testing all the possible combinations of parameters and testing just a few configurations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant