Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UID lookup is bad #5

Open
james-antill opened this issue Sep 22, 2020 · 1 comment
Open

UID lookup is bad #5

james-antill opened this issue Sep 22, 2020 · 1 comment

Comments

@james-antill
Copy link

If you can't find a user you should use the UID not the empty string. Here:

...then two lines later you should print u.Username not u.Name:

o = u.Name

...the first problem is repeated for group lookup error path.

@james-antill
Copy link
Author

You could also save a bit of space/time by creating the map as map[uint64]string and then testing before you have to do strconv.Itoa().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant