Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear message in ResetError response for major alarms #181

Open
gavanderhoorn opened this issue Oct 16, 2023 · 0 comments
Open

Unclear message in ResetError response for major alarms #181

gavanderhoorn opened this issue Oct 16, 2023 · 0 comments
Labels
enhancement New feature or request rv:0.1.1 Reported in MotoROS2 0.1.1 todo Not an issue, just a TODO

Comments

@gavanderhoorn
Copy link
Collaborator

While working on #14, I ran into a situation where I had at least one major alarm active and as part of testing tried to use the reset_error service to reset the controller.

As major alarms can't be reset (that way), this didn't work -- as expected.

But the service result returned by MotoROS2 wasn't very informative:

motoros2_interfaces.srv.ResetError_Response(
  result_code=motoros2_interfaces.msg.MotionReadyEnum(value=101),
  message='Robot has an active ALARM'
)

while technically true -- there is still, at least, one active alarm -- we might perhaps try to provide a better message in case someone tries to reset major alarms.

The PP shows "can't reset major alarm" in the message area whenever you try to reset those. Not sure whether we can pick up on that, or whether we could perhaps check the type of alarm(s) that remain(s) and return a different motoros2_interfaces.msg.MotionReadyEnum value in cases where some alarms can't be reset.

@gavanderhoorn gavanderhoorn added enhancement New feature or request rv:0.1.1 Reported in MotoROS2 0.1.1 todo Not an issue, just a TODO labels Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request rv:0.1.1 Reported in MotoROS2 0.1.1 todo Not an issue, just a TODO
Projects
None yet
Development

No branches or pull requests

1 participant