Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tolerances for starting and ending position #254

Open
ted-miller opened this issue May 17, 2024 · 0 comments
Open

Update tolerances for starting and ending position #254

ted-miller opened this issue May 17, 2024 · 0 comments
Labels
todo Not an issue, just a TODO

Comments

@ted-miller
Copy link
Collaborator

Originally from here: #233 (comment)

believe that Ros_Controller_IsInMotion() is not strict enough. Specifically START_MAX_PULSE_DEVIATION should be decreased. (Or make a new constant for "END deviation".) (Maybe make this configurable in yaml?)

A brief test indicated that the fb pos trails the cmd pos by about .0009 radians. If my calculations are right, for some axes (such as GP12 T axis) that's only 24 pulse counts. So, once the increment-queue is empty, Ros_Controller_IsInMotion would immediately return false, even though the robot is still moving. [This could cause the robot to think it's finished while outside of the final tolerance position.]

I'm also suspicious that the difference between fb and cmd could shrink as the robot is decelerating. This might make it easier for other axes to also exceed the threshold.

@gavanderhoorn gavanderhoorn added the todo Not an issue, just a TODO label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
todo Not an issue, just a TODO
Projects
None yet
Development

No branches or pull requests

2 participants