Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I think it would be better if I put in a viewpager. #7

Closed
saechimdaeki opened this issue Oct 21, 2019 · 8 comments
Closed

I think it would be better if I put in a viewpager. #7

saechimdaeki opened this issue Oct 21, 2019 · 8 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@saechimdaeki
Copy link
Contributor

May I change the botom Nav and Fragment a little to make them turn into left and right swipe with a viewpager between Discover and Favorites Fragment?

@YassinAJDI
Copy link
Owner

@saechimdaeki I don't think you do need a VIewPager for that. You can use some animation for Fragment in and Fragment out. Another option which is recommended is to use Navigation component which will make this very easy.

@YassinAJDI YassinAJDI added question Further information is requested enhancement New feature or request labels Oct 21, 2019
@saechimdaeki
Copy link
Contributor Author

Do you mean that when you move Fragment through botom Nav, you want to have animation effect?

@saechimdaeki
Copy link
Contributor Author

@YassinAJDI Well, I will start with some Fragments animation or something.

@2tanayk
Copy link

2tanayk commented Dec 25, 2020

May I work on this issue?and it would be really great if I get more details regarding this issue :)

@saechimdaeki
Copy link
Contributor Author

@2tanayk I think you can send an email directly to the master after opening the PR after doing it once.
Because YassinAJDI, the master, doesn't seem to do GitHub anymore.

@2tanayk
Copy link

2tanayk commented Dec 27, 2020

Ohh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants
@YassinAJDI @saechimdaeki @2tanayk and others