#24 Migrate to null-safety

[jxstxn1]

Addressing Issue #24.
Successfully migrated the project to Null-Safety

Please let me know if I have to do further changes to get the Hacktoberfest Approval

[YazeedAlKhalaf]

will try to check it later today.
thanks for the awesome contribution.

[jxstxn1]

No Problem
Thank you for your fast response

[yahu1031]

@jxstxn1 Just give them a Try. And maintain the style of your coding same everywhere.

[jxstxn1]

@yahu1031 Are you able to test it, because my System is telling me that my Developer Licence doesn't be the Licence which is used in the project.

[yahu1031]

lemme try

[yahu1031]

@jxstxn1 Better add missing return types for the code. and found this issue

Restarted application in 477ms.

════════ Exception caught by widgets library ═══════════════════════════════════
The following assertion was thrown building ValueListenableBuilder<Box<bool>>(dirty, state: _ValueListenableBuilderState<Box<bool>>#44d22):
'package:flutter/src/material/theme_data.dart': Failed assertion: line 350 pos 12: 'colorScheme?.brightness == null || brightness == null || colorScheme!.brightness == brightness': is not true.

The relevant error-causing widget was
ThemeModeBuilder
When the exception was thrown, this was the stack
#2      new ThemeData
#3      App.build.<anonymous closure>
#4      ThemeModeBuilder.build.<anonymous closure>.<anonymous closure>
#5      _ValueListenableBuilderState.build
#6      StatefulElement.build
#7      ComponentElement.performRebuild
#8      StatefulElement.performRebuild
#9      Element.rebuild
#10     ComponentElement._firstBuild
#11     StatefulElement._firstBuild
#12     ComponentElement.mount
...     Normal element mounting (7 frames)
#19     SingleChildWidgetElementMixin.mount
#20     Element.inflateWidget
#21     Element.updateChild
#22     ComponentElement.performRebuild
#23     _InheritedProviderScopeElement.performRebuild
#24     Element.rebuild
#25     ComponentElement._firstBuild
#26     ComponentElement.mount
#27     _InheritedProviderScopeElement.mount
...     Normal element mounting (7 frames)
#34     SingleChildWidgetElementMixin.mount
...     Normal element mounting (21 frames)
#55     Element.inflateWidget
#56     Element.updateChild
#57     RenderObjectToWidgetElement._rebuild
#58     RenderObjectToWidgetElement.mount
#59     RenderObjectToWidgetAdapter.attachToRenderTree.<anonymous closure>
#60     BuildOwner.buildScope
#61     RenderObjectToWidgetAdapter.attachToRenderTree
#62     WidgetsBinding.attachRootWidget
#63     WidgetsBinding.scheduleAttachRootWidget.<anonymous closure>
(elided 13 frames from class _AssertionError, class _RawReceivePortImpl, class _Timer, dart:async, and dart:async-patch)
════════════════════════════════════════════════════════════════════════════════

EDIT(SOLUTION) :
It is because when you have colorScheme property, you can't use brightness of a ThemeData. use brightness in colorSheme.

[yahu1031]

@jxstxn1 Sorry to tell you, this cannot be approved AFAIK, It has a big bug. Fix it and your PR will be accepted after the testing 😄
If you have discord ping me || Mr.Minnu#1031 ||

[jxstxn1]

@jxstxn1 Sorry to tell you, this cannot be approved AFAIK, It has a big bug. Fix it and your PR will be accepted after the testing 😄

Yes Im fixing the AppTheme bug right now.
If there are any more bugs tell me

[yahu1031]

@jxstxn1 Sorry to tell you, this cannot be approved AFAIK, It has a big bug. Fix it and your PR will be accepted after the testing 😄

Yes Im fixing the AppTheme bug right now. If there are any more bugs tell me

@jxstxn1 yes there is. i can't record it(I don't have good app). Ping me in discord or Twitter(find in my profile)

[jxstxn1]

@jxstxn1 Sorry to tell you, this cannot be approved AFAIK, It has a big bug. Fix it and your PR will be accepted after the testing 😄

Yes Im fixing the AppTheme bug right now. If there are any more bugs tell me

@jxstxn1 yes there is. i can't record it(I don't have good app). Ping me in discord or Twitter(find in my profile)

I pinged you on twitter

[yahu1031]

@jxstxn1 The issue is, It builds the UI but it keeps shivering. IDK why?. When I hover, it shows loading hover overall the app and it overlays on all apps. Nothing can be able to do with it. Just run and stop the app. That's it. Better you run the app once.

[YazeedAlKhalaf]

I am sorry, but I don't have time to review the changes. They are a lot and need a lot of time.

[yahu1031]

I am sorry, but I don't have time to review the changes. They are a lot and need a lot of time.

@YazeedAlKhalaf LOL, I can handle it but need a fix. This PR is not so stable. It is still buggy. I asked him to check it.

[YazeedAlKhalaf]

@jxstxn1
This PR has been sitting here for more than 2 months, I will close it for now but if you can enhance it or split it, it will be great.
Thanks a lot!