Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] SignTool fails to handle spaces in path #119

Closed
theAeon opened this issue Mar 23, 2022 · 3 comments
Closed

[BUG] SignTool fails to handle spaces in path #119

theAeon opened this issue Mar 23, 2022 · 3 comments

Comments

@theAeon
Copy link

theAeon commented Mar 23, 2022

ℹ️ Info

Version: 3.4.0

💬 Description

In the constructor for getCertificateDetails.certificateDetailsProcess the powershell command does not sanitize $powershellSubjectOutputFilePath properly and fails when there is a space in the path. Easily fixable by single-tick quoting the variable.
@YehudaKremer
Copy link
Owner

Hello @theAeon

Thanks for the report

fix like that: cd8d076
?

@YehudaKremer YehudaKremer reopened this Mar 23, 2022
@YehudaKremer YehudaKremer reopened this Mar 23, 2022
@YehudaKremer
Copy link
Owner

I publish a new version (3.4.1) with this fix, please check if it solves the problem.

@theAeon
Copy link
Author

theAeon commented Mar 23, 2022

yup, all set.

@theAeon theAeon closed this as completed Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@YehudaKremer @theAeon