Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: locate msix assets path from script file directory if necessary #197

Merged
merged 1 commit into from
May 21, 2023
Merged

feat: locate msix assets path from script file directory if necessary #197

merged 1 commit into from
May 21, 2023

Conversation

lijy91
Copy link
Contributor

@lijy91 lijy91 commented May 20, 2023

When I depend on msix in another package, the msix assets path cannot be obtained when calling create. I added the logic to find the package config from the directory where the script file is located.

List<String> arguments = [];
// ...
await Msix(arguments).create();

https://github.com/leanflutter/flutter_distributor/blob/a112f0a82cf10041f856154415dcb5e0de1d2c89/packages/flutter_app_packager/lib/src/makers/msix/app_package_maker_msix.dart#L59

@YehudaKremer YehudaKremer self-assigned this May 20, 2023
@YehudaKremer
Copy link
Owner

Hello

I will try to test and approve this PR in the next day

Thank you

@YehudaKremer YehudaKremer merged commit 6e0ad9d into YehudaKremer:main May 21, 2023
@YehudaKremer
Copy link
Owner

LGTM 👍

Available in version 3.13.1

Thank you @lijy91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants