Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for stereo separation on quick photo capture settings #1759

Closed
paradoxical-autumn opened this issue Apr 18, 2024 · 12 comments
Closed
Assignees
Labels
enhancement Suggested addition of a new feature. setting Proposal for a user-adjustable setting triaged This issue has been assessed

Comments

@paradoxical-autumn
Copy link

Is your feature request related to a problem? Please describe.

Currently, the Quick Photo Capture settings has an option to capture stereo photos but no option to set the stereo separation. I've found that the default separation set here hurts my eyes.
(It also seems a bit random right now? Some times when I capture the photo, it's fine, other times it's a literal pain to look at.)

Describe the solution you'd like

A slider value allowing for a custom stereo separation to be set for quick photos. This could be added to the PhotoCaptureSettings component.

Describe alternatives you've considered

  • Manually changing this on the photo capture manager on the avatar
  • Reference hacking to the photo capture manager on the avatar and then to the stereo separation field

Additional Context

No response

Requesters

paradoxical_autumn (Discord username) // paradox19 (IGN)

@paradoxical-autumn paradoxical-autumn added the enhancement Suggested addition of a new feature. label Apr 18, 2024
@paradoxical-autumn
Copy link
Author

paradoxical-autumn commented Apr 18, 2024

I completely forgot to add an example of the "absurd" default option for stereo separation.

I enabled "Capture stereo photo" and took a picture of a computer right in front of me in this example. Everyone with VR in the session complained that this is too much separation
2024-04-18 22 13 42

@shiftyscales
Copy link
Collaborator

The relative depth of the stereo finger photo appears to scale with the size of the user that takes the photo.

At small user scales, the image is much flatter/closer together, at larger user scales the image is much deeper/more separated.

The following three images were taken at ~0.6x scale, 0.05x scale, and 1.2x scale.

The most separated one is the one that was taken at the largest (1.2x) user scale.

2024-04-18 22 08 27
2024-04-18 22 08 29
2024-04-18 22 08 43

Seeking input from @Frooxius.

@shiftyscales shiftyscales removed their assignment Apr 18, 2024
@lxw404
Copy link

lxw404 commented Apr 18, 2024

Stereo separation is just one factor to this. The bigger problem with the stereo pictures taken by the default camera is that the focal point is at infinity (both cameras for the left and right eyes are not converging to a point). This can, and has caused a lot of strain in viewing such photos, since in real life your eyes are always trying to focus on individual objects, not everything at once.

When you view objects in 3D, your eyes actually rotate and converge towards a single focal point which corresponds to rotating the individual 2 stereo cameras in the same way. There really should be an additional option for a convergence point with toggle which can be set by either a laser projecting into the scene and hitting an object, or by specifying an actual position/slot.

@Frooxius
Copy link
Member

We can add setting for this.

I'd just like to note that currently the separation is 65 mm, which is around the average distance between people's eyes.

@paradoxical-autumn
Copy link
Author

paradoxical-autumn commented Apr 19, 2024

Thank you!

Are you also going to try and fix how the distance is currently used in local space rather than global space, causing it to be affected by avatar scale? Or should I make a separate report for that?

@shiftyscales shiftyscales added setting Proposal for a user-adjustable setting triaged This issue has been assessed labels Apr 19, 2024
@Frooxius Frooxius self-assigned this Apr 23, 2024
@Frooxius
Copy link
Member

Added in 2024.4.24.33, thanks!

@shadowpanther
Copy link

@Frooxius the default value in the Settings is 6.50mm, is this correct?

The average IPD is about 6.5cm (65mm), ten times as much.

@paradoxical-autumn

This comment was marked as outdated.

@Banane9
Copy link

Banane9 commented Apr 26, 2024

Just loaded up the game to check, and the default is indeed 6.50 mm - which as @shadowpanther points out is about a tenth of what it should be for the human average.

Screenshot of the Quick Photo Captures settings, showing a default of 6.5mm IPD

Here's a quick overview on some averages: https://www.researchgate.net/figure/Mean-interpupillary-distance-mm-values-in-various-age-groups_tbl2_281069573

@shadowpanther
Copy link

@/Frooxius the default value in the Settings is 6.50mm, is this correct?
The average IPD is about 6.5cm (65mm), ten times as much.

@shadowpanther froox misspoke, the in game value is 65mm iirc

I never changed the value in my settings, and it's 6.5mm for me.

I can't take finger photos (quest controllers via steam link and steamvr), so can't confirm if that's the settings display issue or the setting value issue.

@Frooxius
Copy link
Member

Ooop, yeah, that's supposed to be 65 mm

@Frooxius Frooxius reopened this Apr 26, 2024
@Frooxius
Copy link
Member

Ok it's fixed. If you already saved your settings you'll need to update this manually though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Suggested addition of a new feature. setting Proposal for a user-adjustable setting triaged This issue has been assessed
Projects
Archived in project
Development

No branches or pull requests

6 participants