Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New contact session notification notifies you when the user starts in local home #2035

Closed
epicEaston197 opened this issue May 14, 2024 · 10 comments
Labels
bug Something isn't working as intended. duplicate This issue already exists.

Comments

@epicEaston197
Copy link

epicEaston197 commented May 14, 2024

Describe the bug?

New contact session notification notifies you when the user starts in local home

To Reproduce

  1. Add someone as a contact
  2. Make sure you have the new contact session notification bare minimum is toast
  3. have the added contact start Resonite
  4. You notice that you still received the notification along with the session name (which is likely "local")

Expected behavior

New contact session notification should not notify me of someone starting in their local home

Screenshots

image

Resonite Version Number

Beta 2024.5.7.505

What Platforms does this occur on?

Windows

What headset if any do you use?

Desktop

Log Files

DESKTOP-DAN95E7 - 2024.5.7.505 - 2024-05-17 15_21_03.log

Additional Context

due to how similar new contact session notification is this could potentially also affect the new public session notification as well

Reporters

@epicEaston197

@epicEaston197 epicEaston197 added the bug Something isn't working as intended. label May 14, 2024
@Nytra
Copy link

Nytra commented May 14, 2024

logs are always required

@epicEaston197
Copy link
Author

logs are always required

okay I'll get them and add them to the issue
my head moves at a mile a minute and I just wanted to report the issue before I forgot

@Frooxius
Copy link
Member

How is the Private session started?

Can you see the Private session in the Contacts list shortly after it's started?

@Frooxius Frooxius added the needs more information More information is requested about this issue. label May 17, 2024
@epicEaston197
Copy link
Author

epicEaston197 commented May 17, 2024

How is the Private session started?

Can you see the Private session in the Contacts list shortly after it's started?

In the contacts list it is always hidden but I receive the notification for it starting
I occasionally see a notification that someone has started their local home and when I click on it I can't join them because it immediately goes private

@Frooxius
Copy link
Member

Is this specifically for the Local home? Or does this happen for other sessions too?

How are the users on the other end starting the Private session? Can you provide reproduction steps for that?

@epicEaston197
Copy link
Author

epicEaston197 commented May 17, 2024

Is this specifically for the Local home? Or does this happen for other sessions too?

Yes this only happens to the local world

How are the users on the other end starting the Private session?

Any future private worlds created will not be affected by this bug only local home

Can you provide reproduction steps for that

I'm not sure the replication steps that I provided should work

  1. Add someone as a contact
  2. Make sure you have the new contact session notification bare minimum is toast
  3. have the added contact start Resonite
  4. You notice that you still received the notification along with the session name (which is likely "local")

I've also attached log files it's a little big because I was just playing as normal but as soon as the issue came up I immediately closed the game

@epicEaston197 epicEaston197 changed the title New contact session notification still notifies you of a new session even if it's private New contact session notification notifies you when the user starts in local home May 17, 2024
@epicEaston197
Copy link
Author

Alright I tweaked the issue with a new discovery this only affects the local home

@Nytra
Copy link

Nytra commented May 17, 2024

Probably related to #1359

@epicEaston197
Copy link
Author

Probably related to #1359

The thing is if I click on the notification it's immediately set to private

@ProbablePrime
Copy link
Member

I'm going to treat this as a duplicate of #1359 because sessions like this should not be producing notifications like that.

@ProbablePrime ProbablePrime closed this as not planned Won't fix, can't repro, duplicate, stale May 18, 2024
@shiftyscales shiftyscales added duplicate This issue already exists. and removed needs more information More information is requested about this issue. labels May 21, 2024
@shiftyscales shiftyscales removed their assignment May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended. duplicate This issue already exists.
Projects
None yet
Development

No branches or pull requests

5 participants