Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy setting in YLT / PhantomasWrapper.js #78

Closed
abhishek0001 opened this issue May 14, 2015 · 5 comments
Closed

Proxy setting in YLT / PhantomasWrapper.js #78

abhishek0001 opened this issue May 14, 2015 · 5 comments

Comments

@abhishek0001
Copy link

Hi,
I tried running YLT in a corporate environment behind a firewall with the git based setup. I kept running into an access denied error.

Adding an option to accept the proxy parameter in PhantomasWrapper.js as a workaround works for me. What is the correct way to set up the corporate proxy with YLT, not sure if this is a bug/missed option?

Thanks
P.S. Can you mention the msvs_version=2013 option to npm install for Windows users for node-gyp setup somewhere in the documentation. Git, bower, npm all need additional proxy set up configuration params too.

@gmetais
Copy link
Collaborator

gmetais commented May 18, 2015

Hi @abhishek0001!

You are right, there's no way to set up a proxy for the moment.

Phantomas can work with proxy settings. But it doesn't send the settings to analyze-css. Analyze-css re-downloads the CSS files one by one, so an improper proxy setting will skip most of the CSS files and give a erroneous score.

I opened this issue: macbre/phantomas#500
I think we'd better wait for a fix (or fix this issue ourself) before adding the option in YLT.


About the installation process for Windows, I don't really understand what this msvs_version refers to (I'm not a Windows user). Do you mind editing the Wiki to add this mention? That would be great!
You could also add a small chapter about proxy settings on Git, bower and npm.

@abhishek0001
Copy link
Author

Thanks for the quick answer. I will try and update the wiki soon.

For windows installation, YLT uses lwip package which in turn uses node-gyp. node-gyp needs recompilation and needs the msvs_version=2013 flag for locating C++ compiler/libs.

Links for more details:
https://www.npmjs.com/package/lwip
https://github.com/TooTallNate/node-gyp#installation
nodejs/node-gyp#339
http://stackoverflow.com/questions/14278417/cannot-install-node-modules-that-require-compilation-on-windows-7-x64-vs2012

@macbre
Copy link

macbre commented Sep 15, 2016

@gmetais, it took a while, but it's finally there - macbre/phantomas#663

@gmetais
Copy link
Collaborator

gmetais commented Sep 16, 2016

You rule @macbre !

@gmetais
Copy link
Collaborator

gmetais commented Dec 20, 2016

Fixed by #213.

@gmetais gmetais closed this as completed Dec 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants