Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same secret multiple times in the same file #134

Closed
gustavotabares opened this issue Feb 21, 2019 · 2 comments
Closed

Same secret multiple times in the same file #134

gustavotabares opened this issue Feb 21, 2019 · 2 comments
Labels
duplicate The issue has already already been reported.

Comments

@gustavotabares
Copy link

Hello,

I'm trying to scan using detect-secrets --all-files and I noticed that the tool does not detect multiple instances of the same secret in a single file. It will simply flag the first instance found. The comment located here makes me believe that this is by design. Is it possible to change this behavior or is the tool not designed for this?

@KevinHock
Copy link
Collaborator

Hi @gustavotabares, @domanchi and I have had some discussions around this. However we've kind of punted dealing with this particular issue in the recent past. Line numbers are purposely not part of the secret hash because when lines move around we don't want to re-alert, but I don't see why we couldn't have a count of the secret and keep track of it that way. It is kind of a nice-to-have IMO though.

Thanks for making this a GitHub issue 👍 In summary it is possible to change this behavior, it's just that we haven't addressed it yet.

@domanchi
Copy link
Contributor

This is heavily similar to #53, so closing this issue in favor of the older one.

@KevinHock KevinHock added the duplicate The issue has already already been reported. label May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate The issue has already already been reported.
Projects
None yet
Development

No branches or pull requests

3 participants