Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyOpenSSL and service_identify should be in an extras_require #49

Closed
jolynch opened this issue Jun 2, 2017 · 1 comment
Closed

pyOpenSSL and service_identify should be in an extras_require #49

jolynch opened this issue Jun 2, 2017 · 1 comment

Comments

@jolynch
Copy link
Contributor

jolynch commented Jun 2, 2017

Since fido doesn't actually import anything from pyOpenSSL and is meant to be installed as a library, we shouldn't be depending on it as an install_requires.

Instead we should use an extras_requires (see docs)

This way we don't have to depend on cryptography which is a pain to compile.

@jolynch
Copy link
Contributor Author

jolynch commented Jun 2, 2017

https://github.com/twisted/twisted/blob/69b30c9a9b74f44180b8118ce9fde69a70bcfe15/src/twisted/python/_setup.py#L90

Twisted already has an extra_requires for precisely this reason :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant