Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all available annotation types for binary annotations #41

Closed
kaisen opened this issue May 30, 2017 · 2 comments
Closed

Support all available annotation types for binary annotations #41

kaisen opened this issue May 30, 2017 · 2 comments

Comments

@kaisen
Copy link
Member

kaisen commented May 30, 2017

According to the zipkin thrift spec, binary annotations can be of types bool, bytes, int, double, and string. py_zipkin currently only supports string binary annotations.

@codefromthecrypt
Copy link

codefromthecrypt commented Jun 5, 2017 via email

@kaisen
Copy link
Member Author

kaisen commented Jun 5, 2017

Thanks @adriancole, good to know!

@kaisen kaisen closed this as completed Jun 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants