Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update multiple dependencies #64

Merged
merged 1 commit into from
Sep 19, 2019
Merged

Update multiple dependencies #64

merged 1 commit into from
Sep 19, 2019

Conversation

cortinico
Copy link
Collaborator

@cortinico cortinico commented Sep 15, 2019

AGP to 3.5.0
Kotlin to 1.3.50
Retrofit to 2.6.1
RxJava2 to 2.2.11
Detekt to 1.0.1

@cortinico cortinico added this to the 1.3.0 milestone Sep 15, 2019
@cortinico cortinico self-assigned this Sep 15, 2019
@cortinico
Copy link
Collaborator Author

Apparently we're using some Gradle API that has been removed in 5.6.
We need to investigate that further

Gradle to 5.6
AGP to 3.5.0
Kotlin to 1.3.50
Retrofit to 2.6.1
RxJava2 to 2.2.11
Detekt to 1.0.1
@cortinico
Copy link
Collaborator Author

@macisamuele successfully rebased. Can I ask you to review this one?

Copy link
Collaborator

@macisamuele macisamuele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are happy, so do I :)

🚢

@macisamuele macisamuele merged commit ee4b22d into master Sep 19, 2019
@macisamuele macisamuele deleted the update-deps branch September 19, 2019 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants