Update make test to run pre-commit hooks on the whole codebase #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macisamuele
approved these changes
Feb 4, 2020
There was a problem hiding this comment.
Makefile changes looks good to me.
Get green travis and feel free to merge.
Side note: Currently on travis we do cache directories. It might be worth caching ~/.cache/pre-commit and ~/.cache/pip to speed up python and pre-commit setups (a follow-up will be totally fine for this)
cortinico
added a commit
that referenced
this pull request
Feb 4, 2020
Update make test to run pre-commit hooks on the whole codebase
This was referenced Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was discussing with @macisamuele to eventually run all the precommit hooks on
make test. This will prevent developers that don't have pre-commit installed to submit code that is invalid.