This repository has been archived by the owner on Apr 18, 2018. It is now read-only.
Don't remove entries from handle_to_request_map. #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since it's a WeakValueDict, no memory leak will be caused by not removing entries, and in some cases entries are used even after COMPLETE messages. Fixes Yelp#13
yyejun
pushed a commit
that referenced
this pull request
Jan 9, 2014
Don't remove entries from handle_to_request_map.
yyejun
pushed a commit
that referenced
this pull request
Jan 9, 2014
yyejun
pushed a commit
that referenced
this pull request
Jan 9, 2014
yyejun
pushed a commit
that referenced
this pull request
Jan 10, 2014
Don't remove entries from handle_to_request_map.
yyejun
pushed a commit
that referenced
this pull request
Jan 10, 2014
yyejun
pushed a commit
that referenced
this pull request
Jan 10, 2014
ealogar
pushed a commit
to ealogar/python-gearman
that referenced
this pull request
Jan 19, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it's a WeakValueDict, no memory leak will be caused by not
removing entries, and in some cases entries are used even after
COMPLETE messages.
Fixes #13