Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhacement request: currency converter #77

Open
duvjones opened this issue Sep 26, 2023 · 5 comments
Open

Enhacement request: currency converter #77

duvjones opened this issue Sep 26, 2023 · 5 comments
Assignees
Labels
converter Issues, pull requests or discussions concerning the converter mode. enhancement New feature or request

Comments

@duvjones
Copy link

I was just wondering if something with the currency converter can be improved.
The listings of currencies is rather long, and it would be rather nice if a preset of commonly used currencies can be kept to the top of that list. Around 5 entries would be nice.

@inson1
Copy link

inson1 commented Sep 26, 2023

Why not sort by market capitalization? But that isnt accurate, I guess. 🤔

Or just pinned them to top.
With no default maybe? What should be pinned from the start?

First few links from google
https://coinmarketcap.com/fiat-currencies
https://fiatmarketcap.com/
https://portalcripto.com.br/en/cryptocurrencies/bitcoin-vs-fiat-currency-market-cap/

I think there could be also text box with filtering, so you can find it easier.

@duvjones
Copy link
Author

Pinning the commonly used currencies would be a help.
I am not so sure about having a default because... I use CAD alot (living their) that is something that doesn't usual bode well for quick usage.

@inson1
Copy link

inson1 commented Sep 26, 2023

I meant to have in default pinned few the most used currencies, that could be unpinned. Lets say CNY, USD, EUR, JPY, GBP

That would be enough for most people. Rest can just edit it. - drag and drop to change order + add and delete

And I think there shouldnt be max number of pinned currencies.

@Yet-Zio Yet-Zio self-assigned this Sep 27, 2023
@Yet-Zio Yet-Zio added enhancement New feature or request converter Issues, pull requests or discussions concerning the converter mode. labels Sep 27, 2023
@Yet-Zio
Copy link
Owner

Yet-Zio commented Sep 27, 2023

I understand that the current listings of currencies can be quite extensive, and having a preset of commonly used currencies at the top of the list would be a helpful enhancement. Both of your ideas are pretty good, this was also previously requested in #46 . I will also add a search option to make it more convenient along with the pins. That would solve most of the issues with the large entries, though I don't get that much time to focus on both yetCalc and college nowadays lol.

@Yet-Zio
Copy link
Owner

Yet-Zio commented Sep 29, 2023

I have added a search feature in the new release. Please check it out. :)
Also the API has been changed to https://github.com/fawazahmed0/currency-api since exchangerate.host has been bought by APILayer which makes it no longer fully free, has rate limits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
converter Issues, pull requests or discussions concerning the converter mode. enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants