Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use automaxprocs #16

Closed
rrb3942 opened this issue May 9, 2023 · 2 comments · Fixed by #17
Closed

Don't use automaxprocs #16

rrb3942 opened this issue May 9, 2023 · 2 comments · Fixed by #17
Assignees
Labels
bug Something isn't working

Comments

@rrb3942
Copy link

rrb3942 commented May 9, 2023

I like the automaxprocs library, but I don't think it is correct to use inside of another library that gets imported.

Decisions on how to handle GOMAXPROCS should be left up to the main application, as it can have unintended performance implications depending on the workload.

If you find that cache benchmarks run better with it, consider maybe just using inside of benchmarks.

Was a bit surprised when something started messing with my GOMAXPROCS when I was converting a project over to this library!

@Yiling-J
Copy link
Owner

Thanks and good point! Let me remove that

@Yiling-J Yiling-J self-assigned this May 10, 2023
@Yiling-J Yiling-J added the bug Something isn't working label May 10, 2023
@Yiling-J
Copy link
Owner

@rrb3942 released, please try v0.2.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants