Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ristretto dependency #5

Closed
salarali opened this issue Apr 24, 2023 · 6 comments
Closed

Remove ristretto dependency #5

salarali opened this issue Apr 24, 2023 · 6 comments

Comments

@salarali
Copy link

salarali commented Apr 24, 2023

Would it be possible to move the benchmark_test.go into another folder so that theine-go isnt dependant on ristretto?

@salarali salarali changed the title Clean up go.mod Remove ristretto dependency Apr 24, 2023
@Yiling-J
Copy link
Owner

Thank you for your suggestion, but I think go get won't install test dependencies? So if you use Theine as a package, that's not a problem. To remove it from go mod, I think I have to create a sub module

@Yiling-J
Copy link
Owner

I think you are right, I will remove that file because all benchmarks are moved to go-cache-benchmark-plus repo

@salarali
Copy link
Author

It does add the dependencies because they are listed in go.mod.

@Yiling-J
Copy link
Owner

is that true? I just create a test project and run go get github.com/Yiling-J/theine-go, this is the go mod file:

module box

go 1.20

require github.com/Yiling-J/theine-go v0.2.0

require (
	github.com/gammazero/deque v0.2.1 // indirect
	github.com/klauspost/cpuid/v2 v2.0.9 // indirect
	github.com/zeebo/xxh3 v1.0.2 // indirect
)


@Yiling-J
Copy link
Owner

removed in #6

@salarali
Copy link
Author

Hmm.. I was mistaken. Apologies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants