Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REDO: Add Protection GUI Element for Give Collectible #2990

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

rkwapisz
Copy link
Contributor

Previously closed PRs were a result of me deleting the branches after I'd merged them into my own fork, but I didn't realize that would also close the PR in the base. Whoops.

@rkwapisz rkwapisz changed the title Add Protection GUI Element for Give Collectible REDO: Add Protection GUI Element for Give Collectible Apr 27, 2024
Copy link
Contributor

@gir489returns gir489returns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any particular reason you reordered these?

@rkwapisz
Copy link
Contributor Author

rkwapisz commented Apr 27, 2024

Is there any particular reason you reordered these?

Aesthetics. The features are currently laid out in columns with six elements per group.

Adding this new toggle would have either required a single column of seven, or a new column of one. I decided that instead of making the menu wider, that it would be better visually to reorganize the checkboxes into groups of seven.

I am happy to defer to other preferences, though.

@gir489returns
Copy link
Contributor

gir489returns commented Apr 27, 2024

While the YImMenu project is a hodgepodge of several people's work all slammed together with no regard for UX at all, we generally try to adhere to WYSIWYG design philosophy when we can, because that's generally what ImGui is based upon, or at least tries to.

That being said, if you wish to pitch a new design, it's generally a nice idea to post a screenshot of your new design, so that we can internally weigh the options of accepting the new design, or asking to revert.

@rkwapisz
Copy link
Contributor Author

Here is a screenshot of the proposed new Protection layout with the new Give Collectible checkbox.

image

@gir489returns
Copy link
Contributor

The new design logically makes sense, I can see why you made those changes.

@Yimura Yimura merged commit fcf74bc into YimMenu:master Apr 28, 2024
2 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2024
@rkwapisz rkwapisz deleted the GiveCollectibleUIElement branch May 4, 2024 23:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants