Feature: Infinite Vehicle Ammo #3003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't we already have this? |
|
should also close #1637 |
Surprisingly, no. Not for vehicle weapons. WEAPON::SET_PED_INFINITE_AMMO does not apply to vehicle weapons. |
|
Download the artifacts for this pull request: |
Yimura
reviewed
Apr 30, 2024
Yimura
approved these changes
Apr 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new "Infinite Vehicle Ammo" checkbox to the vehicle menu.
When enabled, any weapons in the player's vehicle, such as Oppressor Mk2 missiles, will have infinite ammo. This includes countermeasures and bombs.
The main difference between this and previous implementation attempts is that SET_VEHICLE_WEAPON_RESTRICTED_AMMO doesn't use weapon hashes and instead simply accesses the vehicle's weapon index.
This is a better long-term solution than trying to directly access a vehicle's weapon hashes since it does not require checks against potential new weapon hashes with future GTAO content updates.
en_us translation forthcoming.
Closes #1021 and #1637.