Increased the maximum length of CEO Name from 15 to 64 characters. #3011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gir489returns
changed the title
|
Download the artifacts for this pull request: |
Yimura
approved these changes
Apr 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will hijack the call to DISPLAY_ONSCREEN_KEYBOARD and increase the size from 15 characters to the maximum the string will hold which is 64 characters. However, there doesn't seem to be an easy way to articulate we made this change to the user at runtime. Without them looking at the code, or just noticing the box is slightly bigger now, the instructions at the top still say (MAX: 15 Characters). It has to be a GXT string, it can't be a string literal, I've tried, it just gets set to blank.