Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workaround]: Remove Start LS Customs Button from LS Customs Menu #3065

Merged
merged 3 commits into from May 6, 2024

Conversation

rkwapisz
Copy link
Contributor

@rkwapisz rkwapisz commented May 6, 2024

After making changes to a vehicle via the LSC script, the game stops responding to mouse and keyboard events. It gets stuck in some sort of transition phase between LSC and freemode. Maybe it's waiting for the drive-out cutscene to finish before returning player control? I'm not sure, but it's 100% reproducible.

Unless someone wants to take a crack at fixing this script, I think we should prevent users from activating it since they're spending actual GTA$.

Yimura
Yimura previously approved these changes May 6, 2024
Copy link
Member

@Yimura Yimura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah for now this is the correct way of handling this.

Long ago this worked beautifully however R* made some changes causing the script to become significantly harder to trigger and use properly.
Ideally if possible another effort should be made to redo this feature by analyzing the scripts and trigger it without doing janky script patches (which are hard to maintain).

@T14D3
Copy link
Contributor

T14D3 commented May 6, 2024

Suiciding works to regain control, and for some use cases the button is pretty handy, so I'd prefer if we just either put a big warning label on it or move it for example to the "Debug" section

@Yimura
Copy link
Member

Yimura commented May 6, 2024

Suiciding works to regain control, and for some use cases the button is pretty handy, so I'd prefer if we just either put a big warning label on it or move it for example to the "Debug" section

Yes indeed however that shouldn't be the solution to this, ideally it would be reworked entirely.

Also I'm interested in these use cases where you'd consider locking your game up would be useful.

Copy link

github-actions bot commented May 6, 2024

Download the artifacts for this pull request:

@T14D3
Copy link
Contributor

T14D3 commented May 6, 2024

Suiciding works to regain control, and for some use cases the button is pretty handy, so I'd prefer if we just either put a big warning label on it or move it for example to the "Debug" section

Yes indeed however that shouldn't be the solution to this, ideally it would be reworked entirely.

Properly functioning rework would definitely be better, yes, but I (personally) feel like making such a function harder to find is better than just outright removing them.

As for use cases, It sometimes works when you are in the bounds of an actual LSC with a vehicle that is too big for the LSC to normally accept it - rare, and highly not stable/repeatable, but IMO enough reason to keep it somewhere

@Yimura
Copy link
Member

Yimura commented May 6, 2024

I'm fine with moving it to debug, @rkwapisz I'm fine with either way. If you could move it to debug somewhere I'd appreciate it.

Yimura
Yimura previously approved these changes May 6, 2024
@rkwapisz
Copy link
Contributor Author

rkwapisz commented May 6, 2024

I think I misinterpreted the ask. I wrapped the button in a NDEBUG check, but I think what you asked for was to put the button inside the actual YimMenu debug window.

@Yimura
Copy link
Member

Yimura commented May 6, 2024

I think I misinterpreted the ask. I wrapped the button in a NDEBUG check, but I think what you asked for was to put the button inside the actual YimMenu debug window.

Yeah indeed, as debug isn't really useful unless we listen to the asserts that ImGui is throwing at us and fix them.

@Yimura Yimura merged commit 499fc6b into YimMenu:master May 6, 2024
1 check passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2024
@rkwapisz rkwapisz deleted the RemoveLSCButton branch May 9, 2024 04:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants