Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix script_event_handler crash #3105

Merged
merged 1 commit into from May 12, 2024
Merged

Fix script_event_handler crash #3105

merged 1 commit into from May 12, 2024

Conversation

Mr-X-GTA
Copy link
Contributor

Fixes #3101

@rkwapisz
Copy link
Contributor

rkwapisz commented May 12, 2024 •
edited

if (scripted_game_event->m_args_size > sizeof(scripted_game_event->m_args))

The game client doesn't check this itself? Blows my mind.

Thanks for the fix.

@Mr-X-GTA
Copy link
Contributor Author

The game client doesn't check this itself? Blows my mind.

It does, but YimMenu does not. The out of bounds array access happens in YimMenu

@Yimura
Copy link
Member

Yimura commented May 12, 2024

It does, but YimMenu does not. The out of bounds array access happens in YimMenu

Indeed, mistake on our part.

@github-actions GitHub Actions
Copy link

Download the artifacts for this pull request:

@Yimura Yimura merged commit ef70781 into YimMenu:master May 12, 2024
1 check passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2024
@Mr-X-GTA Mr-X-GTA deleted the fixsehandler branch May 17, 2024 09:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Yimura Yimura Yimura approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Request]: Block all Crashes from Cherax
3 participants
@Mr-X-GTA @rkwapisz @Yimura